Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Samples] Investigate redundant Check #1933

Open
Manvi-Agrawal opened this issue Sep 25, 2024 · 3 comments
Open

[Samples] Investigate redundant Check #1933

Manvi-Agrawal opened this issue Sep 25, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers low-priority backlog items with low priority

Comments

@Manvi-Agrawal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There exists a typescript test that executes samples in samples.mjs (Code link ) . IMO, it would be good to investigate whether it is relevant in the current scenario after this repo has been enhanced for testing efficiency primarily in #1533 #1797. As per my understanding we are now checking for lint and sample execution for all samples, so it might be a good idea to get rid of redundancy.

Describe the solution you'd like
A clear and concise description of what you want to happen.
Get rid of redundant test if its no longer required.

Describe alternatives you've considered
Dont remove the test if its needed.

Additional context

@Manvi-Agrawal Manvi-Agrawal added enhancement New feature or request needs triage labels Sep 25, 2024
@Manvi-Agrawal Manvi-Agrawal changed the title Investigate redundant Samples Check [Samples] Investigate redundant Check Sep 25, 2024
@sezna sezna added good first issue Good for newcomers low-priority backlog items with low priority and removed needs triage labels Oct 14, 2024
@sezna
Copy link
Contributor

sezna commented Oct 14, 2024

@Manvi-Agrawal Yep, this seems like a redundancy and removing that JS would be practical.

@prkbuilds
Copy link
Contributor

Hi @Manvi-Agrawal @sezna , Can I work on this issue?

@Manvi-Agrawal
Copy link
Contributor Author

@PratikFandade sounds good. This should be fairly straightforward. Let me know if need any help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers low-priority backlog items with low priority
Projects
None yet
Development

No branches or pull requests

3 participants