Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The text in some lessons is broken #5970

Open
THEb0nny opened this issue Sep 21, 2024 · 10 comments
Open

The text in some lessons is broken #5970

THEb0nny opened this issue Sep 21, 2024 · 10 comments
Assignees

Comments

@THEb0nny
Copy link

In some lessons the text is broken due to some characters and makecode interrupts the display of the line.

image
image

@THEb0nny
Copy link
Author

image

@THEb0nny
Copy link
Author

It's worth checking out the other lessons too.

@THEb0nny
Copy link
Author

image

@THEb0nny
Copy link
Author

image
image

@abchatra
Copy link
Collaborator

@ganicke is this a documentation issue?

@ganicke
Copy link
Collaborator

ganicke commented Sep 25, 2024

@abchatra - in a way, yes. Some of those icon type characters don't parse well when uploaded to Crowdin. Crowdin will terminate sentences early when encountered typically.

@ganicke
Copy link
Collaborator

ganicke commented Oct 1, 2024

@abchatra - So, I verified that the source arrives to Crowdin intact.

image

It's when presented in the editor that they truncate strings on certain special characters. In some languages the translators have fixed this by adding the icon chars back in their translation.

image

This seems to be a Crowdin issue. I could send them a bug report for this?

@ganicke
Copy link
Collaborator

ganicke commented Oct 16, 2024

Support message for this sent to Crowdin 10/16. Awaiting a response...

@ganicke
Copy link
Collaborator

ganicke commented Oct 18, 2024

@abchatra - So, I received a good response from Crowdin Support mentioning the possible use of segmentation rules to avoid breaks on the emoji/icon characters:

Hello there, 

For markdown, you can use custom segmentation rules:
https://support.crowdin.com/custom-segmentation/

We have plenty of possible custom modules (https://store.crowdin.com/tags/file-processors),
but changing a segmentation should solve this without much development work. 

In case it wouldn't help, please share with source file sample as an attachment to an email,
a screenshot of how it looks in Crowdin editor, and the project ID (or URL)

Thanks in advance, 
--
Sincerely,
Dima Yashchyshyn
Customer Success Manager

This does require, however, a segmentation (SRX) file added to support EACH source file needing custom segmentation. Otherwise, segmentation could be disabled on the source file and no strings would be parsed leaving the file as one blob text to translate in whole.

Creating an SRX file for these chars would add a new rule to NOT break (dice.md for example):

<rule break="no">
        <beforebreak>[🎲⭐👋]</beforebreak>
        <afterbreak>\s</afterbreak>
</rule>

This doesn't seem like a practical solution at this point. Not sure if modifying the default SRX is possible where we could set the whole range of these emojis to not break.?.?

@abchatra
Copy link
Collaborator

Thanks @ganicke for investigating this. @jwunderl @thsparks FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants