Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Add plugin flow coming from TTK #5751

Closed
maisarissi opened this issue Nov 11, 2024 · 0 comments · Fixed by #5759
Closed

Support Add plugin flow coming from TTK #5751

maisarissi opened this issue Nov 11, 2024 · 0 comments · Fixed by #5759
Assignees
Labels
status:waiting-for-triage An issue that is yet to be reviewed or assigned WIP

Comments

@maisarissi
Copy link
Contributor

maisarissi commented Nov 11, 2024

To support Add plugin flow coming from TTK, we need to provide an additional parameter so they can specify the folder we should be generating the files in:

kiota.openApiExplorer.searchOrOpenApiDescription:
{
      kind: "Plugin",
      type: "ApiPlugin",
      source: "ttk",
      ttkContext,
      projectPath: "c:/app"
}

If the projectPath is not provided, Kiota should use the temp folder.

After creating the files, if the source is ttk, Kiota needs to call TTK back.

Acceptance Criteria

  1. One should be able to provide a projectPath parameter to create the clients/plugins to an specific folder.
  2. If projectPath is not provided, Kiota should create default to the temp folder.
  3. If source is provided, Kiota should call/complete the generation as expected based on the source.
  4. Relative paths should not be allowed. If a relative path is provided, Kiota should thrown an error "Relative path is not supported for projectPath parameter".
@maisarissi maisarissi added the status:waiting-for-triage An issue that is yet to be reviewed or assigned label Nov 11, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Nov 11, 2024
@thewahome thewahome self-assigned this Nov 15, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✔️ in Kiota Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:waiting-for-triage An issue that is yet to be reviewed or assigned WIP
Projects
Status: Done ✔️
Development

Successfully merging a pull request may close this issue.

2 participants