Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllOf implementation alignement #4714

Closed
baywet opened this issue May 23, 2024 · 0 comments · Fixed by #4723
Closed

AllOf implementation alignement #4714

baywet opened this issue May 23, 2024 · 0 comments · Fixed by #4723
Assignees
Labels
generator Issues or improvements relater to generation capabilities. type:bug A broken experience
Milestone

Comments

@baywet
Copy link
Member

baywet commented May 23, 2024

From the discussions:

  1. swap the ordering between this line and the one below
  2. add opposite clauses with and !other.HasAnyProperty()
  3. add todo comment to handle the case when all three of them have properties, and in which case squish inline and root, and make it inherit the reference entry.

(true, not null, not null) when inlineSchema.HasAnyProperty() => AddModelDeclarationIfDoesntExist(currentNode, schema, className, shortestNamespace, CreateInheritedModelDeclaration(currentNode, inlineSchema, operation, classNameSuffix, codeNamespace, isRequestBody, typeNameForInlineSchema)),

@baywet baywet self-assigned this May 23, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota May 23, 2024
@baywet baywet added type:bug A broken experience generator Issues or improvements relater to generation capabilities. labels May 23, 2024
@baywet baywet moved this from Needs Triage 🔍 to Todo 📃 in Kiota May 23, 2024
@baywet baywet modified the milestones: Backlog, Kiota v1.15 May 23, 2024
@baywet baywet moved this from Todo 📃 to In Review 💭 in Kiota May 24, 2024
@github-project-automation github-project-automation bot moved this from In Review 💭 to Done ✔️ in Kiota May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generator Issues or improvements relater to generation capabilities. type:bug A broken experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant