Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update auto-project add workflow to filter out PRs from forks #4689

Closed
baywet opened this issue May 20, 2024 · 0 comments · Fixed by #4768
Closed

Update auto-project add workflow to filter out PRs from forks #4689

baywet opened this issue May 20, 2024 · 0 comments · Fixed by #4768
Assignees
@fey101
Labels
priority:p0 Blocking issue. Loss of critical functions eg security/privacy violation. Bug SLA<=48hrs type:bug A broken experience
Milestone
Kiota v1.15

Comments

@baywet
Copy link
Member

baywet commented May 20, 2024

See #4679 as an example where the PR is from a fork and the workflow failed for security reasons.
This generated a noisy notification to the author, and could create confusion.
We should add a filter on PR add to make sure the PR comes from this repo before running subsequent steps.
@baywet baywet added type:bug A broken experience priority:p0 Blocking issue. Loss of critical functions eg security/privacy violation. Bug SLA<=48hrs labels May 20, 2024
@baywet baywet added this to the Kiota v1.15 milestone May 20, 2024
@baywet baywet added this to Kiota May 20, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota May 20, 2024
@baywet baywet moved this from Needs Triage 🔍 to Todo 📃 in Kiota May 20, 2024
@fey101 fey101 mentioned this issue Jun 4, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo 📃 to Done ✔️ in Kiota Jun 4, 2024
This was referenced Jun 5, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fey101 fey101

Labels
priority:p0 Blocking issue. Loss of critical functions eg security/privacy violation. Bug SLA<=48hrs type:bug A broken experience
Projects
Kiota
Archived in project
Milestone
Kiota v1.15
Development

Successfully merging a pull request may close this issue.

chore: Only run track issue if PR is not from a forked context microsoft/kiota
2 participants
@baywet @fey101