Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different authentication scenarios/platforms #1944

Closed
plamber opened this issue Nov 2, 2022 · 3 comments
Closed

Allow different authentication scenarios/platforms #1944

plamber opened this issue Nov 2, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request TypeScript Pull requests that update Javascript code

Comments

@plamber
Copy link

plamber commented Nov 2, 2022

Hello,
We are looking for a way to configure authentication for the Graph SDK JS for different platforms for the same application:

  • When logged in in Teams I would like to use the Teams SSO to authenticate the calls
  • For SPA applications in Teams we might need to redeem a Graph token from the Teams SSO token (if present)
  • When logged in a browser (outside of Teams) we would like to use AAD authentication without SSO

Please let me know if you require more context regarding this requirement.

Thank you,
Patrick

@baywet baywet self-assigned this Nov 2, 2022
@baywet baywet added enhancement New feature or request TypeScript Pull requests that update Javascript code labels Nov 2, 2022
@baywet
Copy link
Member

baywet commented Nov 2, 2022

Hey @plamber glad to see you here! 👋

SPA in browser: @nikithauc had started a PR a while ago here I know she has a lot on her plate at the moment. Maybe this is something you could take over if you're interested in contributing and if she is ok with that?

Teams SSO: @luismanez is working on that as we speak, stay tuned to PRs on https://github.com/microsoft/kiota-typescript to get some updates and don't hesitate to reach out directly to help him/ work together on it.

We already support node (azure identity), and spfx (thanks to luis) as well as anonymous, and API key auth scenarios. These additional two (mentioned above) should give us a good coverage, let us know if we're missing anything else.

Note: one quick PR you could put together is for the readme table here so we include a link to the SPFx provider, as well as here

@plamber
Copy link
Author

plamber commented Nov 4, 2022

Hi @baywet,
thank you for reaching out. This sounds promising.

@nikithauc and @luismanez, let me know if you need a helping hand for the above topics. I am open to give some support there.

Cheers,
Patrick

@plamber plamber closed this as completed Nov 4, 2022
@nikithauc
Copy link
Contributor

@plamber Thank you! I will let you know if I need any help. I will prioritize this PR to help you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request TypeScript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

3 participants