Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group kiota dotnet repositories #238

Closed
23 tasks done
baywet opened this issue May 22, 2024 · 4 comments · Fixed by #262 or #285
Closed
23 tasks done

Group kiota dotnet repositories #238

baywet opened this issue May 22, 2024 · 4 comments · Fixed by #262 or #285
Assignees
Labels
area:abstractions Focused on functional module of the product enhancement New feature or request type:enhancement Enhancement request targeting an existing experience

Comments

@baywet
Copy link
Member

baywet commented May 22, 2024

We initially made the choice to split the dotnet dependencies into multiple repositories to enable better isolation of concerns.
This has proven to represent mostly coordination overhead, without delivering much additional value (kiota-java and kiota-typescript being good examples of mono repos that work) as:

Suggestion to move to a monorepo for dotnet dependencies and align the versions:

  • create a tests subdirectory here
  • create an abstractions subdirectory
  • move the test project to that subdirectory
  • update the sln reference
  • create an abstractions subdirectory under src
  • move the content in that sub directory
  • update the sln reference
  • for reach other repo than abstractions:
    • copy the src content to a subdirectory in src here
    • copy the test content to a subdirectory in tests here
    • update any abstractions reference to use a project reference instead of a package reference
    • add reference to both projects in the sln
    • merge the changelog information
    • transfer the issues to this repository
    • close the outstanding pull requests, leave a note to re-open on this repo instead
    • update the readme to tell people the content has been moved
    • archive the repository
    • disable the ADO pipeline
  • update the workflows to build/test all projects
  • update the ADO pipeline to build/publish all packages
  • remove the version in the csproj, set them up so they use build props instead
  • add a build props, with the version set to the uppermost patch version
  • rename the repo to kiota-dotnet (and update the csproj repository reference)
  • publish a new release

This will also unable the bundle package microsoft/kiota#4636 work

@baywet baywet added enhancement New feature or request type:enhancement Enhancement request targeting an existing experience labels May 22, 2024
@baywet baywet added this to Kiota May 22, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota May 22, 2024
@baywet baywet moved this from Needs Triage 🔍 to Todo 📃 in Kiota May 22, 2024
@KennethHoff
Copy link

For clarity; this is referring to merging the GitHub Repositories, not the NuGet packages?

@baywet
Copy link
Member Author

baywet commented Jun 8, 2024

Correct

@pjmagee
Copy link

pjmagee commented Jun 10, 2024

Mono repo is soooo much easier to deal with

@andrueastman
Copy link
Member

Re-opening to close after task regarding migration of issues and and repo readmes are cleaned up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:abstractions Focused on functional module of the product enhancement New feature or request type:enhancement Enhancement request targeting an existing experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants