Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After selecting a currency that does not allow decimal values, then switching to another converter, calculator will not allow decimal input #1832

Open
Shidouuu opened this issue May 16, 2022 · 3 comments · May be fixed by #1896
Open

After selecting a currency that does not allow decimal values, then switching to another converter, calculator will not allow decimal input #1832

Shidouuu opened this issue May 16, 2022 · 3 comments · May be fixed by #1896

Comments

@Shidouuu
Copy link

Steps To Reproduce

  1. Goto Currency screen
  2. Select a currency that does not allow decimal values (such as JPY)
  3. Switch to another converteer (e.g. length)
  4. Cannot enter decimal values :(

Going back to the Currency screen and selecting a currency that does allow decimals fixes this.

2022-05-16.15-44-54.mp4
@DeclanGazil02
Copy link

I would like to fix this! Can this be assigned to me? This would be my first time contributing to an open source, so if anyone knew where this is handled in the code, that would be a ton of help!

@DeclanGazil02
Copy link

Actually, I believe I have just fixed it, I will submit a PR soon.

@DeclanGazil02
Copy link

Before I submit, may this thread be viewed and marked "triage approved", if applicable?

@DeclanGazil02 DeclanGazil02 linked a pull request Sep 23, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed decimal usability in converter section DeclanGazil02/calculator
2 participants
@Shidouuu @DeclanGazil02