Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change app service slot setting back to false #267

Open
pbell97 opened this issue Jan 12, 2024 · 0 comments
Open

Unable to change app service slot setting back to false #267

pbell97 opened this issue Jan 12, 2024 · 0 comments

Comments

@pbell97
Copy link

pbell97 commented Jan 12, 2024

Using the yaml task AzureAppServiceSettings@1 here , I am able to make any variable's slotSetting equal to true in my app service's appsettings configuration, but I am unable to change it back to false without manual intervention (which is not possible in my prod environment). The value of the setting always updates but not the slotSetting boolean value.

After some investigation I've noticed that AzureAppServiceSettings@1 calls appServiceUtility.updateAndMonitorAppSettings(...) which is here, and that calls both appService.patchApplicationSettings(...) (line 164) and appService.patchApplicationSettingsSlot(...) (line 192) which is here. The value of the property is always updated by patchApplicationSettings, but not the 'slotSetting' boolean value. I believe the problem is in patchApplicationSettingsSlot. If I set an appsetting with slotSetting = true then the code here will update the value and slotSetting value to true, however if slotSetting = false then it ignores it completely and will not edit the slotSetting value back to false.

This is causing a problem in our deployment because there are some variables that were previously set as slotSetting = true that we now wish to change to slotSetting = false so that the value will move over when we swap slots for our app service in azure from staging to production. However because of this bug the slotSetting is never changed to false even though we explicitly tell it to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant