Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Use file-scoped namespace on sample code #25

Open
AndrewKeepCoding opened this issue Nov 21, 2024 · 2 comments · May be fixed by #28
Open

[FEATURE] Use file-scoped namespace on sample code #25

AndrewKeepCoding opened this issue Nov 21, 2024 · 2 comments · May be fixed by #28

Comments

@AndrewKeepCoding
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Sample.xaml.cs uses block-scoped namespace slightly losing a bit of readability, also losing consistency because GenAIModel.cs uses file-scoped namespace.

Image

Image

Describe the solution you'd like

It'd be better Sample.xaml.cs uses file-scoped namespace.

Image

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context

There are other sample code that also uses block-scoped namespace.

@AndrewKeepCoding
Copy link
Contributor Author

I could create a PR for these sample code.

@nmetulev
Copy link
Member

Thanks Andrew - please feel free to submit a PR and update the samples - this is a good suggestion - thank you

@AndrewKeepCoding AndrewKeepCoding linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants