Overwriting parameters in inherited instruments #32

AdriaanRol · 2016-02-12T16:33:04Z

Currently parameters are added to an instrument in the init. Once a parameter is added it is not possible to overwrite this by using another add_parameter command. When inheriting an instrument you generally want to overwrite inherited functions as well as some parameters. This is currently not possible.

The current workaround would be to overwrite the entire init and copy paste all the add_parameter commands that were in the parent class. I think it makes sens to run super().init(...) and then only overwrite those parameters that are overwritten.

alexcjohnson · 2016-02-28T22:56:48Z

Three options come to mind:

already possible: call del self.parameters['snazzy'] before self.add_parameter('snazzy', ...)
we could add a keyword to add_parameter that enables overwriting
to avoid even creating such parameters in the first place... this is a little hacky, but you could call super().__init__ after the new params with a pattern like:

def __init__(self, ...):
    # first add the overridden parameters
    self.add_parameter('override1', ...)
    self.add_parameter('override2', ...)
    ...

    # tell add_parameter() to not raise on overrides, just return without adding
    self.ignore_override_errors = True
    super().__init__(...)
    # turn off this behavior afterward
    self.ignore_override_errors = False

we could even get fancy and make this a context manager so you can't forget to clean up:

with self.ignore_override_errors:
    super().__init__(...)

AdriaanRol · 2016-03-02T16:26:44Z

@alexcjohnson
I like "the with self.ignore_override_errors" option, however I would make it a private function.

giulioungaretti · 2016-06-01T11:45:22Z

@AdriaanRol can you provide some examples where you would want to do this ?

MerlinSmiles · 2016-06-01T11:55:30Z

@giulioungaretti you could have a base awesomeness instrument, and have special drivers for models or versions that have a slightly different commandset or extended functionality or something like that.

giulioungaretti · 2016-06-01T12:03:03Z

@MerlinSmiles fair point !

giulioungaretti · 2016-06-01T12:05:16Z

So the proposed solution is to have an explicit overwrite_parameter function.
@AdriaanRol and @MerlinSmiles what you think ?

MerlinSmiles · 2016-06-01T12:19:11Z

@giulioungaretti would it break anything to be able to overwrite existing ones by default?
One might of course break something by doing so...

AdriaanRol · 2016-06-01T12:43:29Z

I would propose as an argument in add_parameter, not a special function.
The current trick @alexcjohnson proposed based on del self.parameters['parameter_name'] does the trick but it is hard to gaurantee that all traces get removed if we at a later stage decide to change the functionality.

giulioungaretti · 2016-06-01T12:43:42Z

I think it make more sense be explicit and avoid confusion. In this way you
will be warned both if you overwrite when adding and vice versa.
On Wed, 1 Jun 2016 at 14:19, MerlinSmiles [email protected] wrote:

@giulioungaretti https://github.com/giulioungaretti would it break
anything to be able to overwrite existing ones bu default?
One might of course break something by doing so...

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
qdev-dk-archive#32 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ACkcNzOExni8ynUAWYIXnkegF_9aCBIrks5qHXi_gaJpZM4HZLTb
.

giulioungaretti · 2016-06-01T12:47:49Z

@AdriaanRol not sure what you mean with traces.
It's in general harder to reason about parameters (especially if they have default values, as it would be in this case) when refactoring.

giulioungaretti · 2017-05-07T12:42:05Z

@AdriaanRol how about implementing as you proposed an add_praemter(...., overwrite=False) ?

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen · 2021-07-08T14:45:18Z

This is now possible via #3125

AdriaanRol added the enhancement label Feb 12, 2016

alexcjohnson mentioned this issue Apr 27, 2016

Ats9870 dev branch #66

Closed

alexcjohnson mentioned this issue May 13, 2016

Metadata #107

Merged

giulioungaretti self-assigned this Jun 1, 2016

jenshnielsen referenced this issue in jenshnielsen/Qcodes Jun 1, 2017

fix: Make do1d pre-flush VISA buffers (#32)

88ce106

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Jun 22, 2017

fix: Make do1d pre-flush VISA buffers (#32)

2af7da3

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Jun 27, 2017

fix: Make do1d pre-flush VISA buffers (#32)

78b1302

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Jul 7, 2017

fix: Make do1d pre-flush VISA buffers (#32)

ebc547b

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Jul 18, 2017

fix: Make do1d pre-flush VISA buffers (#32)

e5a8222

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 3, 2017

fix: Make do1d pre-flush VISA buffers (#32)

08a5bd8

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 3, 2017

fix: Make do1d pre-flush VISA buffers (#32)

4b2a036

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 7, 2017

fix: Make do1d pre-flush VISA buffers (#32)

9d58d7f

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 9, 2017

fix: Make do1d pre-flush VISA buffers (#32)

f604598

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 10, 2017

fix: Make do1d pre-flush VISA buffers (#32)

275b502

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 16, 2017

fix: Make do1d pre-flush VISA buffers (#32)

da1ff94

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 18, 2017

fix: Make do1d pre-flush VISA buffers (#32)

01268d3

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 22, 2017

fix: Make do1d pre-flush VISA buffers (#32)

d6e46d3

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Sep 21, 2017

fix: Make do1d pre-flush VISA buffers (#32)

1fe49a8

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Oct 27, 2017

fix: Make do1d pre-flush VISA buffers (#32)

cc94778

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Nov 21, 2017

fix: Make do1d pre-flush VISA buffers (#32)

cc8d22d

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Nov 23, 2017

fix: Make do1d pre-flush VISA buffers (#32)

aa2dd90

Make do1d flush the buffers of the involved instruments. This is to avoid instruments getting out of sync with their messages and consequently delivering garbage data.

jenshnielsen assigned jenshnielsen and unassigned giulioungaretti Jul 20, 2018

caenrigen mentioned this issue May 27, 2021

Extract doc strings from dynanically added paramters #1151

Closed

caenrigen mentioned this issue Jun 8, 2021

A new way of adding parameters that allows overriding inherited parameters (and sphinx auto documentation) #3098

Open

4 tasks

jenshnielsen closed this as completed Jul 8, 2021

jenshnielsen mentioned this issue Jul 8, 2021

Make it possible to set parameters as attribues and document these using a parser #3188

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Overwriting parameters in inherited instruments #32

Overwriting parameters in inherited instruments #32

AdriaanRol commented Feb 12, 2016

alexcjohnson commented Feb 28, 2016

AdriaanRol commented Mar 2, 2016

giulioungaretti commented Jun 1, 2016

MerlinSmiles commented Jun 1, 2016

giulioungaretti commented Jun 1, 2016

giulioungaretti commented Jun 1, 2016

MerlinSmiles commented Jun 1, 2016 •

edited

Loading

AdriaanRol commented Jun 1, 2016

giulioungaretti commented Jun 1, 2016

giulioungaretti commented Jun 1, 2016

giulioungaretti commented May 7, 2017

jenshnielsen commented Jul 8, 2021

Overwriting parameters in inherited instruments #32

Overwriting parameters in inherited instruments #32

Comments

AdriaanRol commented Feb 12, 2016

alexcjohnson commented Feb 28, 2016

AdriaanRol commented Mar 2, 2016

giulioungaretti commented Jun 1, 2016

MerlinSmiles commented Jun 1, 2016

giulioungaretti commented Jun 1, 2016

giulioungaretti commented Jun 1, 2016

MerlinSmiles commented Jun 1, 2016 • edited Loading

AdriaanRol commented Jun 1, 2016

giulioungaretti commented Jun 1, 2016

giulioungaretti commented Jun 1, 2016

giulioungaretti commented May 7, 2017

jenshnielsen commented Jul 8, 2021

MerlinSmiles commented Jun 1, 2016 •

edited

Loading