Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dds/tree] UndoRedoHandler is not exported from experimental/dds/tree/src/index.ts #23028

Open
TheLarkInn opened this issue Nov 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@TheLarkInn
Copy link
Member

TheLarkInn commented Nov 7, 2024

Describe the bug

UndoRedoHandler is not exported from experimental/dds/tree/src/index.ts. This is problematic because when you are using typescripts "moduleResolution": "Bundler", it becomes impossible to override or work around this bug by using deep imports.

Discovered this in version 2.4, but looking at 2.10/GitHub Source it appears this is still a problem
 

To Reproduce

Steps to reproduce the behavior:

  1. Consume this API in a typescript file with moduleResolution: 'bundler':
import type { SharedTreeUndoRedoHandler } from '@fluid-experimental/tree';
  1. See the typescript error that this package cannot be found.

Expected behavior

UndoRedoHandler should either have a proper package export entry in the package.json OR UndoRedoHandler should be exported from index.ts

@TheLarkInn TheLarkInn added the bug Something isn't working label Nov 7, 2024
@tylerbutler
Copy link
Member

@microsoft/fluid-cr-tree - Is this on your radar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants