Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _createDataStoreWithProps api #22994

Closed
wants to merge 3 commits into from
Closed

Remove _createDataStoreWithProps api #22994

wants to merge 3 commits into from

Conversation

tyler-cai-microsoft
Copy link
Contributor

@tyler-cai-microsoft tyler-cai-microsoft commented Nov 5, 2024 •
edited
Loading

AB#856
#22993

Description

Removes APIs that have been deprecated. We have tried to move away from _createDataStoreWithProps as this causes collisions when creating live datastores. Solutions involved aliasing. The original issue with the removal was that there was no way to put in props. Added the initialState parameter to PureDataObjectFactory.createInstanceWithDataStore as pass in props.

Remove APIs

  • IContainerRuntimeBase._createDataStoreWithProps
  • ContainerRuntime._createDataStoreWithProps

Alternatives

  • PureDataObjectFactory.createInstanceWithDataStore allows props to be passed in via the initialState parameter.

@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Nov 5, 2024
@tyler-cai-microsoft tyler-cai-microsoft linked an issue Nov 5, 2024 that may be closed by this pull request
Remove _createDataStoreWithProps #22993
Open
@tyler-cai-microsoft tyler-cai-microsoft requested a review from a team as a code owner November 5, 2024 23:57
anthony-murphy
anthony-murphy reviewed Nov 6, 2024
View reviewed changes
.changeset/gold-maps-cut.md Outdated
@@ -0,0 +1,100 @@
---
"@fluidframework/agent-scheduler": minor
Copy link
Contributor

@anthony-murphy anthony-murphy Nov 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while technically true, i'd trim this remove example, tests, experimental, private, and cases where the change really shouldn't be impactful

@tyler-cai-microsoft tyler-cai-microsoft requested a review from a team as a code owner November 6, 2024 00:26
@github-actions github-actions bot added the public api change Changes to a public API label Nov 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> [email protected] ci:start
> http-server ./public --port 1313 --silent


> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

http://localhost:1313/docs/start/tree-start/
- (3430:89) 'here' => https://github.com/microsoft/FluidFramework/blob/main/packages/dds/tree/docs/main/merge-semantics.md (HTTP 404)


Stats:
  447786 links
    3441 destination URLs
       2 URLs ignored
       0 warnings
       1 errors

 ELIFECYCLE  Command failed with exit code 1.

@tyler-cai-microsoft
Copy link
Contributor Author

Closing due to branch rename to 2.20 #22996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-murphy anthony-murphy anthony-murphy left review comments

Assignees
No one assigned
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch changeset-present public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove _createDataStoreWithProps
2 participants
@tyler-cai-microsoft @anthony-murphy