Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure /join response for Pending nodes is consistent #6659

Open
eddyashton opened this issue Nov 19, 2024 · 0 comments
Open

Ensure /join response for Pending nodes is consistent #6659

eddyashton opened this issue Nov 19, 2024 · 0 comments

Comments

@eddyashton
Copy link
Member

Noticed while debugging something else:

2024-11-19T11:32:39.363335Z -0.001 0   [info ] ../src/node/node_state.h:623         | !!! Received join response:
{
  "node_id": "80a95a1c87127f0c9351df36cba2d70bca6f85f05bd15e09493c6c17ea27c908",
  "node_status": "Pending"
}

2024-11-19T11:32:39.365522Z -0.002 0   [info ] ../src/node/node_state.h:623         | !!! Received join response:
{
  "node_status": "Pending"
}

I think this is harmless, but may bite us in future. Should refactor the code to ensure the response is the same, whether the node is newly added or already known to be pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant