Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timing logic in presence of colspans #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix timing logic in presence of colspans #146

wants to merge 1 commit into from

Conversation

dipamsen
Copy link
Contributor

@dipamsen dipamsen commented Oct 2, 2024

Fixes #145

@proffapt
Copy link
Member

proffapt commented Oct 2, 2024

Can you share the ss of what this issue was like and what it's like after the fix?

@dipamsen
Copy link
Contributor Author

dipamsen commented Oct 2, 2024

Can you share the ss of what this issue was like and what it's like after the fix?

image

Before After

@proffapt
Copy link
Member

proffapt commented Oct 2, 2024

@harshkhandeparkar @rohan-b-84 can one of you verify that these changes aren't breaking anything else?

@proffapt
Copy link
Member

proffapt commented Oct 7, 2024

@harshkhandeparkar @rohan-b-84 @shikharish ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshkhandeparkar harshkhandeparkar Awaiting requested review from harshkhandeparkar

@rohan-b-84 rohan-b-84 Awaiting requested review from rohan-b-84

@shikharish shikharish Awaiting requested review from shikharish

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Doesn't take into account proper time difference when cells are in colspan
2 participants
@dipamsen @proffapt