Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Go to 1.21, and update relevant pkgs #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated Go to 1.21, and update relevant pkgs #111

wants to merge 2 commits into from

Conversation

AryanSharma9917
Copy link

Notes for Reviewers

This PR fixes #108

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Sep 15, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@AryanSharma9917
Copy link
Author

@theBeginner86, could you please give this PR a look?

@theBeginner86
update go.sum
f025f22 
Signed-off-by: Pranav Singh <[email protected]>
theBeginner86
theBeginner86 approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@theBeginner86 theBeginner86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theBeginner86
Copy link
Member

Don't forget to run go mod tidy after updating go mod 👍

@theBeginner86
Copy link
Member

theBeginner86 commented Oct 22, 2023 •
edited
Loading

@AryanSharma9917
Will you please consider fixing DCO checks? https://github.com/meshery/meshery-cpx/runs/17937243510

@theBeginner86 theBeginner86 added the area/ci Continuous Integration / Build and Release label Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theBeginner86 theBeginner86 theBeginner86 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/ci Continuous Integration / Build and Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[chore] update Go to 1.21, and update relevant pkgs
2 participants
@AryanSharma9917 @theBeginner86