include accounts in prerequisites #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesRudolph
approved these changes
Apr 22, 2024
| @@ -12,13 +12,15 @@ This terraform module is used to integrate AWS into a meshStack instance as a me | |||
|
|
|||
| - [Terraform installed](https://learn.hashicorp.com/tutorials/terraform/install-cli) | |||
| - [AWS CLI installed](https://docs.aws.amazon.com/cli/latest/userguide/getting-started-install.html) | |||
| - Three accounts to segregate accounts by function. | |||
| - management account: organization management account, the account that hosts the AWS Organization | |||
| - meshcloud account: meshStack will use this account to host the IAM users used by meshStack | |||
There was a problem hiding this comment.
s: we should probably change the naming of this to "meshStack" account to avoid any confusion potential here
There was a problem hiding this comment.
Agreed, I opened a separate PR for that: #17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.