Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erase tool segfault #222

Open
propugnator101 opened this issue Feb 2, 2023 · 13 comments
Open

Erase tool segfault #222

propugnator101 opened this issue Feb 2, 2023 · 13 comments
Labels
bug Something isn't working needs testing Unable to reproduce the issue. Might be platform/hardware/godot related

Comments

@propugnator101
Copy link

erase tool makes the app close itself on windows 11

@BigBoyBarney
Copy link

BigBoyBarney commented Feb 5, 2023

The app crashes on Windows 10 as well using OpenTabletDriver. I built the current main branch
https://github.com/mbrlabs/Lorien/commit/d1aba0753aa4354ec41b93a52510f76540d2a3d9
and it crashes there too.

@baedr
Copy link

baedr commented Feb 17, 2023

I believe I have the same bug. I'm on Fedora Linux and the program closes with "Segmentation fault".
On my machine, the error can be instantly produced by spamming penstrokes and the "b" and "e" key.

@hansemro
Copy link
Contributor

Duplicate of #153 which has been resolved in v0.6.0 dev.

@BigBoyBarney
Copy link

It has not, I built the main branch and it still crashes

@hansemro
Copy link
Contributor

Can you share Godot's debugger output as it crashes?

@BigBoyBarney
Copy link

Do you mean the godot log files in %appdata%?

Godot Engine v3.5.stable.official.991bb6ac7 - https://godotengine.org
OpenGL ES 3.0 Renderer: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2
Async. shader compilation: OFF

Loaded i18n file: res://Assets/I18n/de.txt
Loaded i18n file: res://Assets/I18n/en.txt
Loaded i18n file: res://Assets/I18n/es.txt
Loaded i18n file: res://Assets/I18n/fr.txt
Loaded i18n file: res://Assets/I18n/it.txt
Loaded i18n file: res://Assets/I18n/ko.txt
Loaded i18n file: res://Assets/I18n/pt-BR.txt
Loaded i18n file: res://Assets/I18n/ru.txt
Loaded i18n file: res://Assets/I18n/tr.txt
Loaded i18n file: res://Assets/I18n/zh-CN.txt
Loaded i18n file: res://Assets/I18n/zh-TW.txt
Stroke points: 46 (22 removed by optimizer)
Stroke points: 28 (12 removed by optimizer)
WARNING: ObjectDB instances leaked at exit (run with --verbose for details).
at: cleanup (core/object.cpp:2070) - ObjectDB instances leaked at exit (run with --verbose for details).

Thanks!

@hansemro
Copy link
Contributor

hansemro commented Feb 20, 2023

@mbrlabs I think we should also release debug binaries since these will dump a backtrace in the log file. This could also be useful for distinguishing engine crashes.

@hansemro
Copy link
Contributor

hansemro commented Feb 20, 2023

@BigBoyBarney Can you try this debug-enabled build and share log? https://github.com/hansemro/Lorien/releases/tag/v0.6.0-debug-test

@BigBoyBarney
Copy link

Now that's interesting. This version doesn't crash.

https://github.com/BigBoyBarney/Lorien/actions/runs/4096398750#artifacts
https://github.com/BigBoyBarney/Lorien/suites/10787140016/artifacts/542252558

The one I built from this 2 weeks ago (which should still be identical to the main branch) did. The artifact was Lorien_v0.6.0-dev.exe, so it is the right branch right? Or is main not the latest one?

Thanks for your help!

@mbrlabs
Copy link
Owner

mbrlabs commented Aug 5, 2023

Is this still crashing for you guys? Here are some fresh (release) build artifacts using Godot 3.5.2: https://github.com/mbrlabs/Lorien/actions/runs/5770814754

@mbrlabs mbrlabs changed the title erase tool Erase tool segfault Aug 5, 2023
@mbrlabs mbrlabs added bug Something isn't working needs testing Unable to reproduce the issue. Might be platform/hardware/godot related labels Aug 5, 2023
@DraconicMentalist
Copy link

I can confirm that as of 02/22/24, I am experiencing this crash. The eraser only seems to crash the program after lines have been drawn with a tablet pen. Using purely a mouse does not cause the crash, although trying to erase with the mouse after drawing a line with the tablet pen will still crash the program.

I am hoping this additional information is relevant:

  • OS: Windows 10
  • Tablet: XP-PEN Artist15.6 Pro Tablet
  • Graphics Card: NVIDIA GeForce RTX 2060 SUPER

@djiamnot
Copy link

I confirm that this is still an issue when drawing with a pen. However, in my case, it's the pen's eraser that causes the segfault. The application's eraser behaves as expected.

This is on Linux, Ubuntu 22.04, x86_64, Wacom Bamboo Create

@mbrlabs
Copy link
Owner

mbrlabs commented Aug 27, 2024

@djiamnot @DraconicMentalist @propugnator101 @BigBoyBarney

I recently ported the project to Godot 4.3, so a lot has changed. Could any of you test this again? Unfortunately i could never reproduce this.

Here are the latest CI builds: https://github.com/mbrlabs/Lorien/actions/runs/10579945908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs testing Unable to reproduce the issue. Might be platform/hardware/godot related
Projects
None yet
Development

No branches or pull requests

7 participants