Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMethod: undefined method `last_comment' #136

Open
jmkim opened this issue Aug 29, 2019 · 1 comment
Open

NoMethod: undefined method `last_comment' #136

jmkim opened this issue Aug 29, 2019 · 1 comment

Comments

@jmkim
Copy link

jmkim commented Aug 29, 2019

When I tried building and testing this with following:

bundle install --path vendor/bundle
bundle exec rake spec

Following error is occured:

rake aborted!
NoMethodError: undefined method `last_comment' for #<Rake::Application:0x000055b2ccc367f0>
/tmp/seed-fu/vendor/bundle/ruby/2.5.0/gems/rspec-core-2.99.2/lib/rspec/core/rake_task.rb:143:in `initialize'
/tmp/seed-fu/Rakefile:5:in `new'
/tmp/seed-fu/Rakefile:5:in `<top (required)>'
/tmp/seed-fu/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>'
(See full trace by running task with --trace)
@jmkim
Copy link
Author

jmkim commented Aug 29, 2019

This error was occurred because of RSpec version limitation:

s.add_development_dependency "rspec", "~> 2.0"

There was API mismatch between Rake 11 and rspec. This was fixed from rspec 3.5.0. Fixed by rspec/rspec-core@8e723fc

Removing the RSpec version limitation will fix this. However, it seems RSpec transition from 2 to 3 should be done before.

jmkim added a commit to jmkim/seed-fu that referenced this issue Aug 29, 2019
`:should` syntax without explicitly enabling the syntax is deprecated in
RSpec. This patch will replace `:should` syntax with `#expect`, which
introduced in RSpec 2.11.

mbleigh#136

Signed-off-by: Jongmin Kim <[email protected]>
jmkim added a commit to jmkim/seed-fu that referenced this issue Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant