-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to rename inputs and outputs for individual nodes #15
Comments
Semi-related question -- I'm noticing that most created modules aren't producing any visible inputs/outputs, is that the current expected state? Or am I perhaps creating modules incorrectly? |
When creating a module, it only creates inputs for ports that are already connected in the graph. That way, it doesn't list all the input ports that aren't actually connected (which there could potentially be many). I just had an idea for the input and output rename: at first I was thinking we'd need to put this in the node parameter dialog. However, something that could be much simpler, is to just make the in/out port names on nodes Maybe we could add an action |
My plan right now is to change the schema of nodes so that each node has an array of strings, |
Currently working on adding |
I've completed a |
I've implemented the SetInName and SetOutName actions. Now we need a way to edit the input and output names in the UI. Slight complication because some input and output names are the empty string, so we can't just click on the names to edit them. |
One of the issues right now, when creating modules, is that the inputs and outputs get assigned generic names ie
in0
,in1
,out0
,out1
. This is obviously not very descriptive. If you combine a set of nodes into a module, you might not even know which input is which.One solution is to allow renaming ins and outs for modules. However, that still has the problem that you might now know which in/out is which when renaming them. So I was thinking, maybe the better solution is to allow renaming ins/outs not just for modules, but for every type of node. That way, before you group nodes into a module, you could rename their ins/outs. Then, when creating the module, it would use the in/out names of the nodes for the in/out names of the module. This would fix the problem of being able to figure out what is what 🤔
The text was updated successfully, but these errors were encountered: