Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 compatibility #39

Closed
Findus23 opened this issue Aug 28, 2019 · 0 comments · Fixed by #41
Closed

PHP 7.4 compatibility #39

Findus23 opened this issue Aug 28, 2019 · 0 comments · Fixed by #41

Comments

@Findus23
Copy link
Member

Findus23 commented Aug 28, 2019

Related to matomo-org/matomo#14821
Currently the plugins shows the following deprecation warning in PHP 7.4:

WARNING [2019-08-28 11:52:26] 17841  /var/www/matomo-beta/plugins/VisitorGenerator/libs/Faker/Faker/Provider/Lorem.php(94): Deprecated - join(): Passing glue string after ar
ray is deprecated. Swap the parameters - Matomo 3.11.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have
 been reported already)                                                                                                                                                      

This has been fixed in fzaninotto/Faker@167d805, so either the library should be updated or the patch applied to remove the warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant