Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Removing idSite URL parameter when in MultiSites view causes odd error #22794

Open
4 tasks done
jalavosus opened this issue Nov 25, 2024 · 2 comments
Open
4 tasks done
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. triaged

Comments

@jalavosus
Copy link

What happened?

After removing idSite parameter from URL when in MultiSites module, user is kicked to a sign-in page with an error.

What should happen?

MultiSites view should work without idSite URL parameter.

How can this be reproduced?

  1. Have a Matomo Cloud instance with multiple sites configured.

Go to MultiSites view by:

  1. Logging in to a Matomo instance with multiple sites configured.
  2. Clicking "All Websites" in the top right corner

Cause crash/error:

  1. In URL, remove idSite parameter. Ex: index.php?module=MultiSites&action=index&idSite=2 --> index.php?module=MultiSites&action=index.
  2. Hit "Enter", "Go", etc.
  3. Get booted to weird signin screen with error:
Screenshot 2024-11-24 at 23 27 16

Note: a sign-in isn't actually necessary here, simply clicking "back" brings everything back to normal (as the URL is reverted).

Matomo version

Latest Matomo Cloud

PHP version

No response

Server operating system

No response

What browsers are you seeing the problem on?

Chrome, Microsoft Edge, Not applicable (e.g. an API call etc.)

Computer operating system

macOS Sequoia 15.0.1

Relevant log output

No response

Validations

@jalavosus jalavosus added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Nov 25, 2024
@michalkleiner
Copy link
Contributor

Hi @jalavosus, can you share what is the use case for removing the url parameter? Yes, we acknowledge Matomo may get into an unexpected state if you remove some URL parts, sometimes unexpectedly so, but it would be good to know what the use case might be if any at all.

@sgiehl
Copy link
Member

sgiehl commented Nov 25, 2024

somehow similar to #22788. There is a general problem when idsite param may be missing or might contain an invalid site id.

@randy-innocraft randy-innocraft added triaged and removed To Triage An issue awaiting triage by a Matomo core team member labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. triaged
Projects
None yet
Development

No branches or pull requests

4 participants