-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obscure OS families #7487
Comments
|
Those changes do make sense to me. I also went through other items, and this is what I suggest:
|
This library had been built based on various code of Matomo. I guess those groupings simply remained unchanged back then. |
Hm, do we need all of them to have a family, though? Not all browsers have a family, if I understand correctly, and having something generic as "unknown", "proprietary", "mobile device" or anything else among those lines would not bring much benefit, IMHO. Same with families that have only 1 OS. |
I've been expanding my icon pack for the library, and noticed, that there are some OS families, which are quite obscure, in a sense, that they are not really OS families, but rather OS types or something. I am talking about
$osFamilies
variable and these specific items in the array:We are just bunching up OSs that have little to no connection to each other. It may also be problematic to keep these lists up-to-date, too. Do we really need these pseudo-families?
There is also
'Other Smart TV' => ['WHS'],
, which probably should be'Whale OS' => ['WHS'],
.I can do the PR to remove/update them, but I think this is worth proper discussion first.
The text was updated successfully, but these errors were encountered: