Feature/volume control #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Normally the application volume for music is set to about 30%. Since that volume level is not changed when streaming the applications sound to a device and the device itself also has volume level the music can be very silent. overall_volume = application_volume * device_volume The idea is to remember the volume level of the device and set the device's volume to 100% while streaming. In that way you eliminate the device's volume and you are just using the computers volume. overall_volume = application_volume * 1 overall_volume = application_volume When you terminate the streaming the remembered device volume is getting restored, otherwise you blow up the users ears. Might be problematic when the application crashes ...
# Conflicts: # pulseaudio_dlna/plugins/renderer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental branch