Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with gradle kotlin-dsl #28

Open
Antimonit opened this issue Nov 28, 2018 · 0 comments · May be fixed by #29
Open

Incompatibility with gradle kotlin-dsl #28

Antimonit opened this issue Nov 28, 2018 · 0 comments · May be fixed by #29

Comments

@Antimonit
Copy link

The plugin itself works great, but it cannot be configured from Gradle written in Kotlin, because the RibbonizerExtension class is not public. That results into unresolved reference: builder, unresolved reference: forcedVariantsNames, etc. and the project cannot by synced.

Following is from helper methods generated by the kotlin-dsl:

/**
 * Configures the [ribbonizer][com.github.gfx.ribbonizer.plugin.RibbonizerExtension] extension.
 *
 * `ribbonizer` is not accessible in a type safe way because:
 * - `com.github.gfx.ribbonizer.plugin.RibbonizerExtension` is not public
 */
fun org.gradle.api.Project.`ribbonizer`(configure: Any.() -> Unit): Unit =
    (this as org.gradle.api.plugins.ExtensionAware).extensions.configure("ribbonizer", configure)

I believe the only change you need to do is to declare the extension as public.

@tnj tnj linked a pull request Feb 2, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant