PR for review (converted report to pdf) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic Changes
Some changes
Add files via upload
added video
added video for the project
project video
readme update
updated readme
|
you don't have to create a new PR for changes, and you were not supposed to close the PR without asking the mentor or reviewer. |
|
Sorry i did not knew that
…On Tue, 26 Jul, 2022, 2:22 pm Nageshbansal, ***@***.***> wrote:
you don't have to create a new PR for changes, and you were not supposed
to close the PR without asking the mentor or reviewer.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2EEAB45LBFLIWF55R7W6D3VV6RN5ANCNFSM54UISH4A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
LGTM. |
SanjeevKrishnan
requested changes
Aug 19, 2022
There was a problem hiding this comment.
@OARSS @mayank4655 @jayantb007 @Rajeev-Gupta555 Repo is well structured, and looks impressive.
In README.md, texts need to be justified.
@Nageshbansal follow this up!
|
@SanjeevKrishnan do you mean justify align the text? |
|
@OARSS, By justifying the text we meant the content of the README.md file should be more relevant, clean( grammar mistakes), etc. |
removed grammatical errors
Readme updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested, the report was converted to pdf. Please review and merge if everything seems good.