Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the "attentionClassDumpUser:" safety feature. #27

Open
jaredsinclair opened this issue Apr 9, 2014 · 3 comments
Open

Comments

@jaredsinclair
Copy link
Contributor

Although it's a clever way to prevent people from shipping BugshotKit to the AppStore, the "class dump" private API reference creates additional hassle for developers. In order to exclude BugshotKit from App Store build configurations, we have several unappealing choices:

  1. Manually create a static library every time master is updated, which makes it likely that the Bugshot library will become outdated compared to the current master branch. (I just discovered mine was 41 commits behind.)

  2. Configure the Xcode project to include a freshly-built static library as a target dependency, which is not as straightforward a process as it should be. I'm not sure it's even possible to do this on a per-build-config basis.

  3. Add a separate target for dev/beta builds.

  4. Manually add/remove the source .h and .m files when submitting to the App Store.

It's much simpler and cleaner to include BugshotKit dynamically, leaving it up to the developer to exclude BugshotKit from release build configurations however she sees fit, perhaps with preprocessor macros. This isn't possible while the "class dump" safety feature is still around.

@mmcdole
Copy link

mmcdole commented Nov 17, 2014

This is also preventing us from submitting our app to beta testers via TestFlight. Now that we have to submit our builds for TestFlight through Apple, they reject our binary.

screen shot 2014-11-16 at 9 30 17 pm copy

@jaredsinclair
Copy link
Contributor Author

I forked BugshotKit and removed that code. I also added an additional trigger: double-tap of the hardware volume buttons. https://github.com/jaredsinclair/BugshotKit

@chadmoone
Copy link

👍 In light of the new Apple beta testing scheme, we have had to transition the way we toggle our test environment configuration (since beta builds are now effectively release builds). Given the new system, this safety feature makes it too difficult to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants