Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2,bug] In gallery view with row layout images are vertically cropped #103

Open
Artiom-M opened this issue Jun 4, 2024 · 3 comments
Open

Comments

@Artiom-M
Copy link

Artiom-M commented Jun 4, 2024

As you can see on this picture:
image
I would expect it to be resized so picture's height matches row height of the gallery.
What I can see is that image is resized correctly, but then expanded:
image

@Artiom-M
Copy link
Author

Artiom-M commented Jun 4, 2024

Just played around and discovered that removing flex-grow is fixing it.
image

@marcantondahmen
Copy link
Owner

Hi, this is geometrically impossible since the rows have a fixed height but the width is flexible. There will be always some cropping. However, the render engine tries to minimize the cropping.

@Artiom-M
Copy link
Author

Artiom-M commented Jun 19, 2024

Yes, if the proportion is so that width will be greater than the content width. However in general case, fixed height is what I want, but in this case it looks like fixed width and cropped height.
So I just want to see the full picture even it is means having bands (vertical or horizontal) around. Something like "fit in" option. Because cropping is often looks ugly, like the bottom left image in my example or middle right. These are both vertical photos...
Could it be also related to the rotation not taken into account for the size calculation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants