Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential security issue: ecall_SSL_read using [user_check] #20

Closed
wyann22 opened this issue Aug 28, 2019 · 2 comments
Closed

potential security issue: ecall_SSL_read using [user_check] #20

wyann22 opened this issue Aug 28, 2019 · 2 comments

Comments

@wyann22
Copy link

wyann22 commented Aug 28, 2019

@similar to issue13, i think it is necessary to add a bound-checking function in ecall_SSL_read.
Image a TLS client which can fetch website contents of any server, we can transfer a pointer pointing to enclave memory like this:
bytes = SSL_read(ssl, (char*)(secret_addr), sizeof(buf));
So the secret memory will be overwritten to the website content like below:
image
Moreover, if the host is not google but controlled by attackers, the secret memory value can be overwritten to arbitrary value like below. (the left terminal is a server controlled by attacker)
image
Basically, attackers can modify to any memory in enclave to any value.
Thanks for guidance from @david-oswald
#18

@david-oswald
Copy link

I think this issue should be merged with #18

@plaublin
Copy link
Collaborator

plaublin commented Sep 3, 2019

Closed because duplicate of #18

@plaublin plaublin closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants