Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming Exercise: Template and solution repository comparison contains unnecessary binary files #9929

Open
maximiliansoelch opened this issue Dec 2, 2024 · 0 comments
Labels
bug exercise Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module

Comments

@maximiliansoelch
Copy link
Member

Describe the bug

When comparing the template with the solution submission, also binary files like .jar are included in the request unnecessarily increasing the request size.

To Reproduce

  1. Go to a programming exercise edit page
  2. Open your browser's dev tools
  3. Click on 'Review Changes' in the Template/Solution Comparison section
  4. Look at the network requests and see that binary files like .jar files are included in the request

Expected behavior

Common binary files like .jar, .exe, etc. should be excluded from these REST requests to decrease the request size.

Screenshots

image image

Which version of Artemis are you seeing the problem on?

7.7.3

What browsers are you seeing the problem on?

Chrome, Safari

Additional context

No response

Relevant log output

No response

@github-actions github-actions bot added assessment Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module lecture Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module labels Dec 2, 2024
@maximiliansoelch maximiliansoelch removed assessment Pull requests that affect the corresponding module lecture Pull requests that affect the corresponding module labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug exercise Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module
Projects
None yet
Development

No branches or pull requests

1 participant