Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lectures: Disable submit button in file upload dialog if no file is uploaded yet #9829

Open
florian-glombik opened this issue Nov 20, 2024 · 2 comments · May be fixed by #9846
Open

Lectures: Disable submit button in file upload dialog if no file is uploaded yet #9829

florian-glombik opened this issue Nov 20, 2024 · 2 comments · May be fixed by #9846
Labels
client Pull requests that update TypeScript code. (Added Automatically!) exercise Pull requests that affect the corresponding module feature fileupload Pull requests that affect the corresponding module good first issue lecture Pull requests that affect the corresponding module priority:low It is not urgent to fix this issue! small user interface

Comments

@florian-glombik
Copy link
Contributor

florian-glombik commented Nov 20, 2024

Is your feature request related to a problem?

When testing a feature I did not upload a file in the file upload lecture unit and tried to save it. I first thought that saving would be broken for file upload exercises but realized that I just did not upload a file (which of course does not make much sense for a file upload lecture unit).

However, Artemis could indicate what the actual issue is to be more self explanatory.

Describe the solution you'd like

Disable the save button until a file is uploaded in the "upload lecture unit view".
Display a tooltip that a file has to be uploaded on the disabled button as long as this has not been done, do not display the tooltip anymore when the button is enabled.

Describe alternatives you've considered

No response

Additional context

Saving does not work before uploading a file, there is no indicator for that in the UI.

fileUploadDisableButton

@florian-glombik florian-glombik added feature good first issue client Pull requests that update TypeScript code. (Added Automatically!) priority:low It is not urgent to fix this issue! user interface lecture Pull requests that affect the corresponding module labels Nov 20, 2024
@github-actions github-actions bot added exercise Pull requests that affect the corresponding module fileupload Pull requests that affect the corresponding module labels Nov 20, 2024
@laxerhd
Copy link

laxerhd commented Nov 20, 2024

That bothered me too.
I'd like to add that feature, if you don't mind.

@laxerhd
Copy link

laxerhd commented Nov 20, 2024

I also noticed, that there are more cases in which one would like to disable the button.
If you have a valid form and then decide to remove the name, the button remains clickable. In this case, however, the red error field will prompt you to add a name. I will also be adressing this issue.

@laxerhd laxerhd linked a pull request Nov 21, 2024 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) exercise Pull requests that affect the corresponding module feature fileupload Pull requests that affect the corresponding module good first issue lecture Pull requests that affect the corresponding module priority:low It is not urgent to fix this issue! small user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants