Added possibility to deploy sample example with terraform #37
Conversation
There was a problem hiding this comment.
Thanks a lot for this cool contribution, @k-a-il!
And I have to apologize that the pipeline is not working correctly.
This is because this repo hasn't had outside collaborators yet, and the pipelines do need secrets (f.e. to start LocalStack Pro) which are not available when the pipelines are triggered from forks (due to security considerations).
We will definitely tackle this in a follow-up to make sure that community contributions can be tested properly as well!
For now, I just triggered the pipeline manually by pushing your commit to a temporary branch and executing it from there, and it's 💚:
https://github.com/localstack-samples/sample-serverless-image-resizer-s3-lambda/actions/runs/11416513029
In another iteration, we could also think about introducing a CI pipeline step to also test your new way of deployment, but I would say that this definitely is out of scope of this PR. 😄
I added a few comments, mostly nitpicks and some questions to discuss. Afterwards these things have been discussed / addressed, we should be good to go! 🚀
There was a problem hiding this comment.
Nice work @k-a-il 🎉 Apologies for the pipeline issues, as mentioned above.
Thanks for adding the Terraform integration—it’s a valuable addition to the sample, enabling automated infrastructure provisioning with tflocal and enhancing the deployment options. Also, appreciate you addressing the nits from Alex before my review! 😄 The structure is very clean, making the code easy to follow and understand.
I have some comments and also same questions around the local_run variable and the current state for aws deployment of the terraform script as highlighted by Alex. Once these are resolved, we should be good to go! 🚀
There was a problem hiding this comment.
Thanks, @k-a-il for the contribution, and for addressing all the comments! 🏅
The new terraform deployment is looking great, and will definitely be useful for terraform users who want to get started with LocalStack! 💯
This PR provides possibility to deploy the app using Terraform, additionally to the bin/deploy.sh script.