Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Stroke LineCap and LineJoin #171

Open
vinhphuctadang opened this issue Dec 14, 2021 · 6 comments
Open

Text Stroke LineCap and LineJoin #171

vinhphuctadang opened this issue Dec 14, 2021 · 6 comments

Comments

@vinhphuctadang
Copy link

vinhphuctadang commented Dec 14, 2021

Hello author and everyone,

When I draw a text string with stroke (using StrokeStringAt), font Roboto-Medium (loaded with truetype package), found the stroke looks strange which does not cover the text, see image below:

image

In the image, there is an "i" and a "t" which has strange stroke, it does not fully "connected". I am expecting the stroke to cover the text, should looks connected.

I tried SetLineCap but looks like it doesn't work, and found there is an issue on that: #155. How do I correctly make it stroke the text?

Regards,
Phuc Ta

@llgcode
Copy link
Owner

llgcode commented Dec 14, 2021

Hello @vinhphuctadang,
I'm afraid I can't help you right now, I have not planned to fix this issue #155. The project draw2d is stand by, I haven't worked on it for a while.
You can either use another library to do this and look at these projects:

If you really need this issue to be fixed I can make an effort (and work on it) or you can submit a PR, I guess the issue is in this file:
draw2dbase/stroker.go
regards,
Laurent

@vinhphuctadang
Copy link
Author

Thank Laurent, really happy to hear from you. Your package is interesting.
Let me have sometimes to look at this issue inside this repo if you are busy.

Bests,

@llgcode
Copy link
Owner

llgcode commented Dec 14, 2021

I will be happy to review your pull request and merge it.

@llgcode
Copy link
Owner

llgcode commented Jan 10, 2022

Hi @vinhphuctadang,
did you find a fix for your issue ?
regards

@vinhphuctadang
Copy link
Author

Sorry, I am packed catching up with new job atm
Will look into this,

Bests,

@llgcode
Copy link
Owner

llgcode commented Jan 15, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants