Fix: vertical bar broken in chart/gear acitivity (issue: #1646) #1673
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya <[email protected]>
llaske
requested changes
Nov 21, 2024
activities/Chart.activity/index.html
Outdated
Comment on lines
24
to
35
| <div id="toolbar-left"> | ||
| <sugar-toolitem ref="activityPal" id="activity-button"></sugar-toolitem> | ||
| <sugar-toolitem | ||
| ref="sharedPal" | ||
| id="network-button" | ||
| :title="l10n.stringNetwork" | ||
| palette-file="sugar-web/graphics/presencepalette" | ||
| palette-class="PresencePalette" | ||
| palette-event="shared" | ||
| @shared="SugarPresence.onShared" | ||
| v-if="SugarPresence" | ||
| ></sugar-toolitem> |
activities/Chart.activity/index.html
Outdated
Comment on lines
37
to
39
| <hr /> | ||
| <sugar-toolitem id="add-button" :title="l10n.stringAddValue" @click="addData"></sugar-toolitem> | ||
| <sugar-toolitem id="remove-button" :title="l10n.stringRemoveValue" @click="removeData"></sugar-toolitem> |
| /* Toolbar separator */ | ||
| .toolbar hr { | ||
| display: inline-block; | ||
| height: 33px; | ||
| margin: 2.5px; | ||
| margin-bottom: -17px; | ||
| /* margin-bottom: -17px; */ |
|
Ok i will make the changes you mentioned. Thanks |
Signed-off-by: Aditya <[email protected]>
|
Hey @llaske i have removed the comments and indentation in my latest commit please have a look |
Signed-off-by: Aditya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the broken vertical line in Chart/Gears activities, ensuring its applicable on all plaforms (issue: #1646)
Steps:
dislay: flexandjustify-content: space-betweento move both the part to ends of both side of screen. and useddislay: flexandalign-item:centreto move hr to correct position.Chrome:
Firefox:
Electron.js app: