Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement in "Missing flag handling in ColorMyWorld" issue #1604

Closed
wants to merge 2 commits into from

Conversation

hharshas
Copy link
Contributor

Added a condition to display name only if flag is not defined. #1603 @llaske

@llaske
Copy link
Owner

llaske commented Apr 21, 2024

Sounds nice.
BTW I've just checked and the matching Emoji exist: https://emojipedia.org/flag-st-vincent-grenadines
It's probably a name mismatch with the one declared in flag.js: https://github.com/llaske/sugarizer/blob/dev/activities/ColorMyWorld.activity/lib/flag.js#L221
Should be interesting to fix it and to ensure there is no mismatch in the flag list.

Fun with flags 😆

@llaske llaske changed the title improvement in "Missing flag handling in ColorMyWorld #1603" issue improvement in "Missing flag handling in ColorMyWorld" issue May 5, 2024
@llaske
Copy link
Owner

llaske commented May 14, 2024

@hharshas do you still work on this PR?

@hharshas
Copy link
Contributor Author

Naah @llaske I am busy rn, you can assign it to others.

@llaske llaske closed this May 15, 2024
@piyushmishraa
Copy link

hi i would like to work on this issue ...can you assign it to me please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants