Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling canvas pointer events when running intro #1420

Closed
wants to merge 4 commits into from

Conversation

mvaibhav77
Copy link

I've made a small change addressing the issue mentioned in #1418. This pull request aims to dynamically enable or disable click events on the canvas based on the presence of elements with the "introjsFloatingElement" class.

Changes Made:

  • Added a click event listener that checks for elements with the "introjsFloatingElement" class.
  • When present, click events on the canvas are disabled; otherwise, they're restored.
  • This change is intended to provide a smoother user experience by allowing the canvas to respond to "introjsFloatingElement" elements dynamically.

I'd appreciate your review and feedback on these alterations.

@llaske
Copy link
Owner

llaske commented Dec 6, 2023

Hmmmm, it works but redefining globally the click event on the body to avoid a small display issue in tutorial is too much.
I don't know if it's possible but we need a less intrusive solution.

@mvaibhav77
Copy link
Author

mvaibhav77 commented Dec 7, 2023

What if I disable the click event only for the element that is highlighted during the intro? But I think that could create some issues but I'll still try.

Edit:
This won't work cause there are tutorials for different activities and disabling them through classes or IDs is not a good way to go about this. I think the first solution is still a better way to do this. We are disabling click events of the canvas and introFloatingItem is not affected by it because it is in a different div. If that is not a good solution according to you then we have to look into the intro.js file to fix this issue.

@samyakshah3008
Copy link
Contributor

Hey @mvaibhav77 are you still working on this issue?

@llaske
Copy link
Owner

llaske commented Apr 15, 2024

Close due to lack of recent activity.

@llaske llaske closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants