Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Listview lines spacing/padding is wrong #1650

Open
llaske opened this issue Jul 21, 2024 · 10 comments
Open

[v2] Listview lines spacing/padding is wrong #1650

llaske opened this issue Jul 21, 2024 · 10 comments
Labels

Comments

@llaske
Copy link
Owner

llaske commented Jul 21, 2024

The list view in v2 has wrong spacing/padding compared to v1.
Specifically: the favorite icon is too close to left size, lines are not centered vertically, ...

lqQPiAq658

@MdSaifAliMolla
Copy link

@llaske fixed it. #1653

@UtkarshSiddhpura
Copy link
Contributor

@llaske @MdSaifAliMolla The change in listview is made in v1 not v2, To make changes in v2 listview see https://github.com/llaske/sugarizer/blob/feature/v2/js/listview.js

@MdSaifAliMolla
Copy link

MdSaifAliMolla commented Aug 22, 2024

@UtkarshSiddhpura please check #1656

@UtkarshSiddhpura
Copy link
Contributor

@UtkarshSiddhpura please check #1656

Yes changes in #1656 are done in v1 not v2 listview

@AdityaKrSingh26
Copy link

On my local setup both v1 and v2 list view appears to be same. @llaske is the issue fixed ?
v1 ->
image
v2 ->
image

@llaske
Copy link
Owner Author

llaske commented Oct 26, 2024

@AdityaKrSingh26 the issue is still here. Are you sure you use http://localhost:8080/v2 when you test the v2?

@AdityaKrSingh26
Copy link

@llaske could you please help me with how start sugarizer on localhost. I have been using it using command "npm start -- --window --sdebug" or chrome --allow-file-access-from-files file:\<Directory>\sugarizer\index.html

@llaske
Copy link
Owner Author

llaske commented Oct 28, 2024

@AdityaKrSingh26 you must install Sugarizer Server, see https://github.com/llaske/sugarizer-server/tree/dev

@AdityaKrSingh26
Copy link

Hey @llaske i have created a pr for v2 where i have resolved the issue. Do let me know if there are any other changes required.
image

@llaske
Copy link
Owner Author

llaske commented Nov 5, 2024

@AdityaKrSingh26 that's better for alignment but the space between lines is now too huge.
We can display 3 fewer lines than before.

Capture.video.du.2024-11-05.21-54-08.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants