Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent assignment deliveries #403

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

parteekcoder
Copy link

Hi @NikhilM98 @ricknjacky ,

I am glad to work on this issue, I would like to mention what I have completed till now

  • Changed the endpoint to /api/v1/assignments/deliveries/:assignmentId to /api/v1/assignments/deliveries to request recent deliveries
  • Moved assignmentId from params to query and also changed this thing in respective pages
  • The new widget will only be shown to the teacher account
  • Only the top 5 deliveries will be shown
  • Added frontend widget at dashboard.ejs
  • Sorted deliveries according to timestamp

Now will fix the tests which got affected by the changes in the endpoints , so for now github test may get failed

I would like to hear any suggestions from you on this PR and I will work upon it

@parteekcoder
Copy link
Author

parteekcoder commented Apr 17, 2023

I created some assignments using the teacher account and submitted that from the student account
Here is the recent assignment deliveries widget which contains the recently submitted assignments
image

@parteekcoder
Copy link
Author

parteekcoder commented Apr 17, 2023

image

these boxes will automatically adjust according to the number of rows and align themselves in new rows when they contain more number of row

@parteekcoder
Copy link
Author

@NikhilM98 @ricknjacky

All these tests are passing because on checking the coverage report I analyzed that there is no test exists for the findAllDeliveries controller
Here is the coverage report for findAllDeliveries
image

image

I will increase the coverage for this by writing tests for this in different scenarios, I am improving coverage at #402

@parteekcoder
Copy link
Author

parteekcoder commented Apr 17, 2023

I wrote 2 new tests for this endpoint
And increased the coverage
image

image

@parteekcoder
Copy link
Author

Hi @NikhilM98 @ricknjacky ,

Now you can review this PR. I am open to new suggestions and will work on them to improve this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants