Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported Sugarizer server's Tour: from Bootstrap to IntroJS #395

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

rockharshitmaurya
Copy link

@rockharshitmaurya rockharshitmaurya commented Mar 12, 2023

Hey, @llaske @NikhilM98 I have ported Sugarizer Server Dashboard Tour from Bootstrap to IntroJS. Please review it.

Refer issue: #363

@NikhilM98
Copy link
Collaborator

Great work!

I haven't reviewed the code yet, I'm waiting for workflow approval from @llaske.

However, there are a few things that can be improved.

  • It will be better to make the target box lighter or transparent, there are some readability issues with this implementation. image

  • This view is completely covered. image

  • There is no "End" button at the end of the tour so user has to click on the "X" button to end the tour. I'll be nice if there is any possibility to add an "End" button.

image

  • The tour restarts every time user loads any view even though the page is already visited.

@NikhilM98
Copy link
Collaborator

There are also some glitches in the tour which can be improved.

image

-

image

@NikhilM98
Copy link
Collaborator

@llaske can you approve the workflow run on this PR?

@rockharshitmaurya
Copy link
Author

hey @NikhilM98, Thanks for the feedback,I will work on making the necessary changes and will update the issue as soon as possible.

@llaske
Copy link
Owner

llaske commented Mar 18, 2023

I'm agree with @NikhilM98 remarks.
Will be nice too to increase width of the title bar:

image

@NikhilM98
Copy link
Collaborator

@rockharshitmaurya can you also fix the failing CI checks?

@parteekcoder
Copy link

@rockharshitmaurya can you also fix the failing CI checks?

there are some lint error, to ease this I opened a PR #400 so that contributors will commit after removing lint errors as it is unnecessary efforts to push code and then resolve linting error, because sometime contributors forget to run command npm run lint before pushing code .It happens with me also

@rockharshitmaurya
Copy link
Author

@rockharshitmaurya can you also fix the failing CI checks?

yeh sure @NikhilM98 sir , I'll be happy to fix that too

@rockharshitmaurya
Copy link
Author

I'm agree with @NikhilM98 remarks. Will be nice too to increase width of the title bar:

image

sure @llaske sir, I'll Take Care of That

@rockharshitmaurya
Copy link
Author

  • There is no "End" button at the end of the tour so user has to click on the "X" button to end the tour. I'll be nice if there is any possibility to add an "End" button.
image

hey @llaske @NikhilM98 , I actually started working on this PR and I have a doubt. all the new tour of sugarizer which are using intro.js do not contain an "End" button, they only have an "X" button on the top right bar to end the tour. So, would it be alright to add an "End" button in the server tour, as it would be different from the others?

@llaske
Copy link
Owner

llaske commented Apr 14, 2023

@rockharshitmaurya no you're right, no end button should be provided.

@yashveeeeer
Copy link

Hi @llaske, is this issue open to work upon?

@llaske
Copy link
Owner

llaske commented Nov 16, 2024

@yashveeeeer yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants