Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a recent assignment deliveries widget in teacher home screen #367

Open
llaske opened this issue Feb 18, 2023 · 10 comments
Open

Add a recent assignment deliveries widget in teacher home screen #367

llaske opened this issue Feb 18, 2023 · 10 comments

Comments

@llaske
Copy link
Owner

llaske commented Feb 18, 2023

Add a widget in teacher dashboard home screen to see recently delivered assignments.

You can take inspiration from the Recent entries Widget:

image

@iks1
Copy link

iks1 commented Feb 23, 2023

I would like to work on this issue , could you please assign it to me !

@iks1
Copy link

iks1 commented Feb 23, 2023

Basically we have to display some kind of table which displays all the records of assignments, classes etc right ?

@llaske
Copy link
Owner Author

llaske commented Feb 23, 2023

I would like to work on this issue , could you please assign it to me !

We don't assign issue. You should check for pull requests linked to an issue you are addressing; if there are none, then assume nobody has done anything.

Basically we have to display some kind of table which displays all the records of assignments, classes etc right ?

Nope just the list of recently delivered assignments.

@parteekcoder
Copy link

@llaske I am implementing this, I have a doubt that where can I get the all delivered assignments or where are they recorded that which student has submitted a student

@parteekcoder
Copy link

@llaske is the endpoint for this task exist or I have to make that , as far as I see there is no endpoint for this task

@NikhilM98
Copy link
Collaborator

@parteekcoder yeah we are going to need some endpoint for this feature. We can either edit an existing endpoint or create a new endpoint.

  • Option 1: Replace /api/v1/assignments/deliveries/:assignmentId endpoint with /api/v1/assignments/deliveries/.

    • Implement filter by assignment using query parameters.
    • Implement sort by timestamp feature.
    • Update the tests and the UI features using this API.
  • Option 2: Create a new endpoint to get all deliveries with filters and sorting.

    • Implement API with sorting/filtering support.
    • Add tests and API documentation for this feature.
    • [Drawback] It will contain redundant logic from get deliveries by assignment feature.

I prefer going with Option 1, although it will may cause backwards incompatibility depending on if Sugarizer is using this API (you can survey this). Moreover, some hardcoded strings in Assignments feature like "Delivered" can me improved.

@parteekcoder
Copy link

yeah thanks @NikhilM98

@parteekcoder
Copy link

hey @NikhilM98 here delivered should be true as we are requesting for assignments that are complete

@Vishalk91-4
Copy link

@llaske, is this issue open for me to work onto

@llaske
Copy link
Owner Author

llaske commented Dec 4, 2023

@Vishalk91-4 sure, let's go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants