Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-commit permission #211

Open
shivam-Purohit opened this issue Mar 16, 2024 · 3 comments · May be fixed by #239
Open

Pre-commit permission #211

shivam-Purohit opened this issue Mar 16, 2024 · 3 comments · May be fixed by #239

Comments

@shivam-Purohit
Copy link
Contributor 

git commit -s -m "create_probe:add api"

hint: The '.git/hooks/pre-commit' hook was ignored because it's not set as executable.

hint: You can disable this warning with `git config advice.ignoredHook false`.

might have to make changes in the commit in the recently add pre-commit hook script to give the necessary permission in the script itself.
@shivam-Purohit shivam-Purohit changed the title Pre-commit permission issue Pre-commit permission Mar 16, 2024
@andoriyaprashant
Copy link

@shivam-Purohit I made some changes within the script
image
By adding chmod +x "$0" to the script, it now has the necessary permissions to run. This change ensures that the script will be executed before each commit
Are these changes correct?

@shivam-Purohit
Copy link
Contributor Author

@andoriyaprashant I think this should work. If you have tested this, you are welcomed to open a pr for the same. Thank you!

@andoriyaprashant andoriyaprashant linked a pull request May 29, 2024 that will close this issue
Open
@andoriyaprashant
Copy link

andoriyaprashant commented May 29, 2024 •
edited
Loading

@shivam-Purohit please review my pull request #239
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure pre-commit hook script is executable andoriyaprashant/litmusctl
2 participants
@shivam-Purohit @andoriyaprashant