Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying Private IP by annotation for VLAN / VPC support #141

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

glennpratt
Copy link
Contributor

@glennpratt glennpratt commented Nov 13, 2023

Fixes #111

Kubernetes node internal IP addresses are not necessarily Linode Private IPs, which must be used for NodeBalancers to communicate with a node. This allows specifying the IP with an annotation in such cases.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

Testing

Manually set the annotation to on dev2-worker-0 to another Linode (that isn't running these services) to prove the change:

image

The canonical test would be on a VLAN/VPC cluster, but this seem sufficient.

@glennpratt glennpratt merged commit 4ced791 into master Nov 28, 2023
1 check passed
@glennpratt glennpratt deleted the private-ip-annotation branch November 28, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CCM Doesn't Work When VLAN IP Is Configured As Node's Internal IP
2 participants