Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VFS Broken since CDRom change? #124

Open
RobLoach opened this issue Jul 13, 2019 · 4 comments
Open

VFS Broken since CDRom change? #124

RobLoach opened this issue Jul 13, 2019 · 4 comments

Comments

@RobLoach
Copy link
Member

RobLoach commented Jul 13, 2019

vendor/libretro-common/vfs/vfs_implementation_cdrom.c: In function ‘retro_vfs_file_seek_cdrom’:
vendor/libretro-common/vfs/vfs_implementation_cdrom.c:49:19: error: ‘libretro_vfs_implementation_file {aka struct libretro_vfs_implementation_file}’ has no member named ‘cdrom’
stream->cdrom.byte_pos = offset;
^~
compilation terminated due to -Wfatal-errors.
Makefile:25: recipe for target 'vendor/libretro-common/vfs/vfs_implementation_cdrom.o' failed
make: *** [vendor/libretro-common/vfs/vfs_implementation_cdrom.o] Error 1

https://github.com/libretro/libretro-common/blob/master/vfs/vfs_implementation_cdrom.c#L49

@RobLoach RobLoach changed the title libretro_vfs_implementation_file has no cdrom VFS Broken since CDRom change? Jul 13, 2019
@kwyxz
Copy link

kwyxz commented Oct 26, 2019

I confirm this at least breaks 4DO and other cores on Haiku libretro/opera-libretro#132

@mudlord
Copy link
Contributor

mudlord commented Jan 7, 2023

Sorry for the bump, but got other cores that use VFS for CDROMs? Wouldn't mind this for testing.

@kwyxz
Copy link

kwyxz commented Feb 16, 2023

@mudlord found another one, Haiku build of neocd_libretro is broken unless HAVE_CDROM is set to 0 when running make:

deps/libretro-common/cdrom/cdrom.c: In function 'cdrom_send_command':
deps/libretro-common/cdrom/cdrom.c:523:7: error: 'else' without a previous 'if'
  523 |       else
      |       ^~~~

@mudlord
Copy link
Contributor

mudlord commented Feb 20, 2023

Thanks very much, was pondering adding my own CD reading stuff to WTFweg, so neocd_libretro would be nice to test too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants