Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant updates of collection used as an array column #19

Open
Nawrok opened this issue Dec 12, 2022 · 0 comments · May be fixed by #20
Open

Redundant updates of collection used as an array column #19

Nawrok opened this issue Dec 12, 2022 · 0 comments · May be fixed by #20

Comments

@Nawrok
Copy link

Nawrok commented Dec 12, 2022

The library supports collections supported as an array column. However, a problem occurs when updating an already existing entity, for which unnecessary statements are executed. If the collection of elements held as array column type has not changed, SQL statements are executed anyway. The problem is in the needsUpdate() method in the SaveProcessor class. The compared reference between persisted and actual collections is never satisfied. Object.deepEquals() alone would be sufficient.

Nawrok added a commit to Nawrok/lc-spring-data-r2dbc that referenced this issue Dec 12, 2022
@Nawrok Nawrok linked a pull request Dec 12, 2022 that will close this issue
Nawrok added a commit to Nawrok/lc-spring-data-r2dbc that referenced this issue Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant