Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename data-cy selectors to data-testid to match playwright default locators #12363

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

rename data-cy selectors to data-testid to match playwright default locators #12363

wants to merge 12 commits into from

Conversation

AmTryingMyBest
Copy link

@AmTryingMyBest AmTryingMyBest commented Oct 13, 2024 •
edited
Loading

There were some remnants of elements that had the default locator for cypress data-cy
I renamed these to data-testid to match the default locator for playwright.

This PR fixes this issue

Signed commits

  • Yes, I signed my commits.

@welcome Welcome
Copy link

welcome bot commented Oct 13, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

@github-actions github-actions bot added the component/ui User Interface label Oct 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2024 •
edited
Loading

View in catalog, Edit in playground or learn how to interpret Meshery Designs

@vishalvivekm
Copy link
Member

@AmTryingMyBest
Thank you for your contributions! Let's discuss this during the Meshery Development call today at 9:00 AM CT. Adding it as an agenda item to the meeting minutes || meeting link.

@leecalcote
Copy link
Member

// @ianrwhitney

ianrwhitney
ianrwhitney reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@ianrwhitney ianrwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you be able to cleanup the whitespace changes? Also are these ids used anywhere? Any tests that will break by just chaning the id and not the test.

ianrwhitney
ianrwhitney reviewed Oct 17, 2024
View reviewed changes
ui/components/MesherySettingsEnvButtons.js Outdated
@@ -210,7 +210,7 @@ const MesherySettingsEnvButtons = () => {
marginRight: '2rem',
}}
disabled={!CAN(keys.ADD_CLUSTER.action, keys.ADD_CLUSTER.subject)}
data-cy="btnResetDatabase"
data-testid="btnResetDatabase"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we have a mix of camel case and kebab case. Any way we can align those?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianrwhitney I made these changes. All names are now written in kebab case. :)

@github-actions github-actions bot added area/docs Documentation update needed area/ci Continuous Integration labels Oct 21, 2024
@l5io
Copy link
Collaborator

l5io commented Oct 21, 2024

🚀 Preview for commit 4c83a30 at: https://67165d042490123e7dc3df95--meshery-docs-preview.netlify.app

@AmTryingMyBest
Copy link
Author

would you be able to cleanup the whitespace changes? Also are these ids used anywhere? Any tests that will break by just chaning the id and not the test.

@ianrwhitney I did the clean up for the whitespaces using lint. No live (e2e) tests are affected by these changes.
This PR may be ready, but when updating I may have run some git commands incorrectly, since now within the PR there's over 5000+ files changed? 😕
Let me know if I went about updating my branch wrongly or if I need to make any changes to or with my PR for this to be done correctly or better.
cc @leecalcote @jerensl

@leecalcote
Copy link
Member

@AmTryingMyBest you'll want to resync your fork and this branch with the latest changes in this upstream repo. A description of this process can be found in CONTRIBUTING.MD.

@github-actions GitHub Actions
Copy link

END-TO-END TESTS

  • Testing started at: October 30th 2024, 9:22:39 am

📦 Test Result Summary

  • ✅ 24 passed
  • ❌ 0 failed
  • ⚠️ 2 flaked
  • ⏩ 0 skipped

⌛ Duration: 3 minutes and 39 seconds

Overall Result: 👍 All tests passed.

[Show/Hide] Test Result Details
Test Browser Test Case Tags Result
1 chromium Add a cluster connection by uploading kubeconfig file unstable ⚠️
2 chromium Transition to disconnected state and then back to connected state unstable ⚠️
3 chromium Transition to ignored state and then back to connected state unstable ⚠️
4 chromium Transition to not found state and then back to connected state unstable ⚠️
5 chromium Delete Kubernetes cluster connections unstable ⚠️
6 firefox Transition to disconnected state and then back to connected state unstable ⚠️
7 firefox Transition to ignored state and then back to connected state unstable ⚠️
8 firefox Transition to not found state and then back to connected state unstable ⚠️
9 firefox Delete Kubernetes cluster connections unstable ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianrwhitney ianrwhitney ianrwhitney left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/ci Continuous Integration area/docs Documentation update needed component/ui User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Remove all Cypress-related files / code / artifacts
6 participants
@AmTryingMyBest @vishalvivekm @leecalcote @l5io @ianrwhitney @Obadha