Add new image and catalog empty card #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Amrutiya <[email protected]>
Signed-off-by: Amit Amrutiya <[email protected]>
leecalcote
requested review from
sudhanshutech,
nebula-aac and
SAHU-01
and removed request for
nebula-aac
leecalcote
approved these changes
Oct 17, 2024
|
@amitamrutiya these cards are used in Cloud and in Meshery UI, right? And so, you're verifying compatibility in both places, right? |
|
Yes @leecalcote . |
Signed-off-by: Amit Amrutiya <[email protected]>
Signed-off-by: Amit Amrutiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new components and updates to the
CustomCatalogmodule, primarily aimed at enhancing the user interface and handling empty states more effectively. The most important changes include the addition of theCatalogCardDesignLogoandEmptyStateCardcomponents, as well as updates to the styling and exports.New Components:
CatalogCardDesignLogoComponent: Added a new component to display design logos with optional zoom effect. (src/custom/CustomCatalog/CatalogCardDesignLogo.tsx)EmptyStateCardComponent: Introduced a component to handle and display empty states with a message and icon. (src/custom/CustomCatalog/EmptyStateCard.tsx)Styling Updates:
CatalogEmptyStateDivandEmptyStateDiv: Added new styled components for empty state handling. (src/custom/CustomCatalog/style.tsx)File and Export Updates:
custom-card.tsxtoCustomCard.tsxand updated imports accordingly. (src/custom/CustomCatalog/CustomCard.tsx)index.tsxto include the new components. (src/custom/CustomCatalog/index.tsx,src/custom/index.tsx) [1] [2] [3] [4]Icon Component:
EmptyStyleIconComponent: Added a new icon component for empty state representation. (src/icons/EmptyStyle/EmptyStyleIcon.tsx,src/icons/EmptyStyle/index.tsx) [1] [2]