-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Prettier and Husky #52
Conversation
Signed-off-by: Antonette Caldwell <[email protected]>
will be adding lint-staged too |
Signed-off-by: Antonette Caldwell <[email protected]>
Merge conflicts... |
"trailingComma": "none", | ||
"jsxBracketSameLine": true | ||
"semi": true, | ||
"tabWidth": 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Should be good now. I fixed the @leecalcote everything looks okay now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI -
To the extent that it is quick to do, we might toss in a dependency check. Not a critical concern. A |
I might be doing something wrong. I got many of these:
with this at the end:
|
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Notes for Reviewers
This PR fixes
This PR setups prettier at the workspace level
Uses husky for
pre-commit
Add
prettier-plugin-organize-imports
to help organize importsSigned commits