-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[storybook] Create missing stories #60
Comments
hey @nebula-aac I wanna work on this but when i'm cd'ing into design-systems and running yarn dev or yarn storybook, i'm getting this following error: can you help out? |
I changed |
seems like adding /src at the end of the import fixes everything, still not sure if its the correct way or not |
We haven't submitted an official release so the |
ah got it, can you assign this to me as well? |
actually i'm not experiencing what you said |
could be a windows issue? |
not sure, i'm using Ubuntu WSL2, I haven't tested this on my Windows pc. |
no problem, i've got it working and I won't commit the 'fix' that i did in order to make it work, can you answer my other questions as well? (see above) |
open pr #68 WIP |
I will have to test your repo after you change it to review so I can check the imports. It should be using the direct imports from the built packages, but since we haven't done an official release, doing this internal in a yarn workspace maybe allowing import towards the |
yeah sure once i'm done with the stories, i'll change the pr status to review and ping you here, then you can check |
by the way @nebula-aac this might become a huge PR as there are a lot of components to cover, should we let it be or do you want to break it down into smaller issues? |
just do some here and there |
done |
Current Behavior
Desired Behavior
Implementation
Acceptance Tests
Mockups
Contributor Guide
The text was updated successfully, but these errors were encountered: