Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storybook] Create missing stories #60

Closed
nebula-aac opened this issue Aug 27, 2023 · 15 comments
Closed

[storybook] Create missing stories #60

nebula-aac opened this issue Aug 27, 2023 · 15 comments

Comments

@nebula-aac
Copy link
Contributor

Current Behavior

Desired Behavior

Implementation

Acceptance Tests

Mockups


Contributor Guide

@kunal70006
Copy link
Contributor

hey @nebula-aac I wanna work on this but when i'm cd'ing into design-systems and running yarn dev or yarn storybook, i'm getting this following error:
Failed to resolve entry for package "@layer5/sistent-components". The package may have incorrect main/module/exports specified in its package.json

can you help out?

@kunal70006
Copy link
Contributor

I changed
import { BaseButton } from '@layer5/sistent-components'; to
import { BaseButton } from '@layer5/sistent-components/src/button'; and it's working, idk if this is the correct way to do it tho

@kunal70006
Copy link
Contributor

seems like adding /src at the end of the import fixes everything, still not sure if its the correct way or not

@nebula-aac
Copy link
Contributor Author

We haven't submitted an official release so the button you have changed from basebutton to button will need to be built and released

@kunal70006
Copy link
Contributor

ah got it, can you assign this to me as well?
also do I have to refer to some mockups for stories or not?

@nebula-aac
Copy link
Contributor Author

actually i'm not experiencing what you said

@kunal70006
Copy link
Contributor

could be a windows issue?

@nebula-aac
Copy link
Contributor Author

not sure, i'm using Ubuntu WSL2, I haven't tested this on my Windows pc.

@kunal70006
Copy link
Contributor

no problem, i've got it working and I won't commit the 'fix' that i did in order to make it work, can you answer my other questions as well? (see above)

@kunal70006 kunal70006 mentioned this issue Aug 30, 2023
10 tasks
@kunal70006
Copy link
Contributor

kunal70006 commented Aug 30, 2023

open pr #68 WIP

@nebula-aac
Copy link
Contributor Author

I will have to test your repo after you change it to review so I can check the imports.

It should be using the direct imports from the built packages, but since we haven't done an official release, doing this internal in a yarn workspace maybe allowing import towards the src directory, instead from the dist directory

@kunal70006
Copy link
Contributor

yeah sure once i'm done with the stories, i'll change the pr status to review and ping you here, then you can check

@kunal70006
Copy link
Contributor

by the way @nebula-aac this might become a huge PR as there are a lot of components to cover, should we let it be or do you want to break it down into smaller issues?

@nebula-aac
Copy link
Contributor Author

just do some here and there

@nebula-aac
Copy link
Contributor Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants