Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert pixels to rem #577

Closed
nebula-aac opened this issue Apr 24, 2024 · 2 comments
Closed

Convert pixels to rem #577

nebula-aac opened this issue Apr 24, 2024 · 2 comments
Labels
kind/enhancement Improvement in current feature

Comments

@nebula-aac
Copy link
Contributor

Current Behavior

We have some properties that are using pixels. Per Sistent Design System in Figma, we're using rem.

MUI also has some functions that will be looking for the rem unit and also implementing unitless, which will cause the existing font sizes, line heights and others that are using pixels currently to not work.

Desired Behavior

Implementation

Acceptance Tests

Mockups

Contributor Guide
@nebula-aac nebula-aac added the kind/enhancement Improvement in current feature label Apr 24, 2024
@nebula-aac
Copy link
Contributor Author

Related to #582

@nebula-aac
Copy link
Contributor Author

This is completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvement in current feature
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nebula-aac