Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components]: Create custom DataFormatter #334

Open
5 tasks
Tracked by #402
nebula-aac opened this issue Nov 14, 2023 · 0 comments
Open
5 tasks
Tracked by #402

[components]: Create custom DataFormatter #334

nebula-aac opened this issue Nov 14, 2023 · 0 comments

Comments

@nebula-aac
Copy link
Contributor

nebula-aac commented Nov 14, 2023

Meshery UI has a component called DataFormatter

https://github.com/meshery/meshery/tree/master/ui/components/DataFormatter

  • Create custom component in custom directory of sistent-components
  • Create CopyIcon on a separate PR first
  • Component relies on lodash, please use good judgement to either place this package in sistent-components or suggest an alternative
  • LaunchIcon is being used from Material UI v4 - create new icon in svg first instead of using LaunchIcon from Material UI v4
  • Use existing components in sistent-components first (inline styles or global)

Contributor Guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant